Fix #4350: Do not check prefix of class type parameters #4363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolasstucki it works for me (apart from the infinite recursion if someone omits the evidence). The other error we were getting was indeed a bug in the code. |
biboudis
reviewed
Apr 27, 2018
| @@ -17,12 +17,14 @@ class TreeCleaner extends tpd.TreeMap { | |||
| /** List of symbols and their types for type aliases `type T = U` */ | |||
| private[this] var aliasesSyms: List[Symbol] = Nil | |||
| private[this] var aliasesTypes: List[Type] = Nil | |||
| private[this] val aliases = newMutableSymbolMap[Tree] | |||
There was a problem hiding this comment.
The changes in this file are not relevant to the fix right? BTW can we add a comment for the aliases var just for symmetry? 😛
biboudis
approved these changes
Apr 27, 2018
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 29, 2018
Fixes buggy condition inserted in scala#4363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO